Ticket #70 (closed defect: fixed)

Opened 2 years ago

Last modified 21 months ago

Fix winetricks package parsing

Reported by: rgovostes Owned by: mike
Priority: major Milestone: 1.3
Component: WineBottler misc Version: 1.1.35
Keywords: Cc:

Description

It looks like WineBottler parses the package list found in the winetricks.sh script:

echo " directx9      MS DirectX 9 user redistributable (not recommended! use d3dx9 instead)"
    echo " directx9-beta MS DirectX 9 user redistributable - beta verb (not recommended! use d3dx9 instead)"
    echo " divx          divx video codec"
    echo " dotnet11      MS .NET 1.1 (requires Windows license, but does not check for one)"
# Doesn't work yet, don't make it public
#    echo " dotnet11sdk   MS .NET Framework SDK Version 1.1 (requires Windows license, but does not check for one; may not work yet)"

It seems to do this by taking substrings of the lines, starting after the "echo-space-quote-space" sequence on each line. However, this ignores the fact that some lines are comments, and so you end up with awkward entries in WineBottler like "ork" with a description of "yet, don't make it publi".

A better solution would be to execute winebottler.sh and have it dump its usage text, then parsing the packages out of that.

Change History

comment:1 Changed 2 years ago by rgovostes

  • Component changed from Wine build script to WineBottler misc

comment:2 Changed 21 months ago by mike

  • Milestone changed from 1.1.44 to 1.1.45

comment:3 Changed 21 months ago by mike

  • Status changed from new to closed
  • Resolution set to fixed

As changing the usage text would imply a change in the parser as well, I go with a comment detector at the moment.

comment:4 Changed 21 months ago by mike

  • Milestone 1.1.45 deleted

Milestone 1.1.45 deleted

comment:5 Changed 21 months ago by mike

  • Milestone set to 1.2
Note: See TracTickets for help on using tickets.