Ticket #70 (closed defect: fixed)
Fix winetricks package parsing
| Reported by: | rgovostes | Owned by: | mike |
|---|---|---|---|
| Priority: | major | Milestone: | 1.3 |
| Component: | WineBottler misc | Version: | 1.1.35 |
| Keywords: | Cc: |
Description
It looks like WineBottler parses the package list found in the winetricks.sh script:
echo " directx9 MS DirectX 9 user redistributable (not recommended! use d3dx9 instead)"
echo " directx9-beta MS DirectX 9 user redistributable - beta verb (not recommended! use d3dx9 instead)"
echo " divx divx video codec"
echo " dotnet11 MS .NET 1.1 (requires Windows license, but does not check for one)"
# Doesn't work yet, don't make it public
# echo " dotnet11sdk MS .NET Framework SDK Version 1.1 (requires Windows license, but does not check for one; may not work yet)"
It seems to do this by taking substrings of the lines, starting after the "echo-space-quote-space" sequence on each line. However, this ignores the fact that some lines are comments, and so you end up with awkward entries in WineBottler like "ork" with a description of "yet, don't make it publi".
A better solution would be to execute winebottler.sh and have it dump its usage text, then parsing the packages out of that.
Change History
comment:1 Changed 2 years ago by rgovostes
- Component changed from Wine build script to WineBottler misc
Note: See
TracTickets for help on using
tickets.
